[PATCH] D90854: [RISCV] Custom lowering of FLT_ROUNDS_

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff marked 4 inline comments as done.
sepavloff added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4620
+  case ISD::FLT_ROUNDS_: {
+    assert(N->getValueType(0) == MVT::i32 && Subtarget.is64Bit() &&
+           Subtarget.hasStdExtF() && "Unexpected custom legalization");
----------------
craig.topper wrote:
> Is this code reachable? This would require `setOperaction(ISD::FLT_ROUNDS_, MVT::i32, Custom)` when Subtarget.is64Bit() is false.
> 
> It's also the default behavior for the target independent type legalizer.
Removed this check. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90854/new/

https://reviews.llvm.org/D90854