[PATCH] D100490: [ELF] Check the Elf_Rel addends for dynamic relocations
Alexander Richardson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 21 06:13:40 PDT 2021
arichardson added inline comments.
================
Comment at: lld/MachO/CMakeLists.txt:58
+ target_link_libraries(lldMachO2 PRIVATE ${XAR_LIB})
+endif()
----------------
thakis wrote:
> If you're adding this here (why?), should you remove it from lld/tools/lld/CMakeLists.txt ?
Sorry that should not be part of this review. Looks like I accidentally squashed another commit into this one.
LLD was failing to build for me -DBUILD_SHARED_LIBS=ON and that seemed like the appropriate fix. Will see if this is still needed with the latest HEAD commit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100490/new/
https://reviews.llvm.org/D100490
More information about the llvm-commits
mailing list