[PATCH] D100490: [ELF] Check the Elf_Rel addends for dynamic relocations

[Alexander Richardson via Phabricator via llvm-commits]

arichardson updated this revision to Diff 339165.
arichardson marked 5 inline comments as done.
arichardson added a comment.
Herald added a subscriber: mgorny.
Herald added a reviewer: int3.
Herald added a project: lld-macho.
Herald added a reviewer: lld-macho.

Use an enum instead of the highly overloaded useSymVA. Hopefully the logic is easier to follow now.

@MaskRay Would you like me to move handling of linker-generated relocations out of Target::getImplicitAddend() and into a new function instead of handling all in one function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100490/new/

https://reviews.llvm.org/D100490

Files:
  lld/ELF/Arch/ARM.cpp
  lld/ELF/Arch/Mips.cpp
  lld/ELF/Arch/X86.cpp
  lld/ELF/Arch/X86_64.cpp
  lld/ELF/Config.h
  lld/ELF/InputSection.cpp
  lld/ELF/OutputSections.cpp
  lld/ELF/OutputSections.h
  lld/ELF/Relocations.cpp
  lld/ELF/SyntheticSections.cpp
  lld/ELF/SyntheticSections.h
  lld/ELF/Target.cpp
  lld/ELF/Thunks.cpp
  lld/ELF/Writer.cpp
  lld/MachO/CMakeLists.txt
  lld/test/ELF/got32-i386-pie-rw.s
  lld/test/ELF/i386-zrel-zrela.s
  lld/test/ELF/ppc64-abs64-dyn.s
  lld/test/ELF/ppc64-long-branch-pi.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100490.339165.patch
Type: text/x-patch
Size: 40248 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210421/a701bab0/attachment.bin>