[PATCH] D100883: [flang][driver][revert] Revert f18 code so that options passed to -W does not not cause compilation termination.

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

These changes LGTM - there's no need to limit `f18`, but we should continue being strict in `flang-new` and reject everything that's not supported.

Please, could you shorten the title of the commit? As per https://llvm.org/docs/DeveloperPolicy.html#commit-messages

> The title should be concise.

I try to limit myself to 50 chars <https://chris.beams.io/posts/git-commit/#limit-50> for the title and 72 chars <https://chris.beams.io/posts/git-commit/#wrap-72> for the body. This is not always possible, but currently your title is >110 chars wide.

Also, from your summary:

> This patch takes away the modification ONLY in f18, so that **the driver** still (...)

Could you clarify which driver you have in mind here? It's clear to me, but I've been working with it quite a lot. I think that it might be unclear to readers unfamiliar with the state of the drivers in Flang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100883/new/

https://reviews.llvm.org/D100883