[PATCH] D100890: [AArch64] Remove an unnecessary parameter to AArch64CallLowering OutgoingArgHandler. NFC.
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 21 00:26:03 PDT 2021
mstorsjo added inline comments.
================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp:175
bool IsWin =
Subtarget.isCallingConvWin64(MF.getFunction().getCallingConv());
+ UseVarArgsCCForFixed = IsWin;
----------------
arsenm wrote:
> This is also broken. This is using the calling convention of the calling function, not the callee
Oh, crap, you're right. And I also have made the same mistake in AArch64ISelLowering. Fix coming up, for both of them. Thanks for noticing it!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100890/new/
https://reviews.llvm.org/D100890
More information about the llvm-commits
mailing list