[PATCH] D99926: [GVN] Introduce loop load PRE
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 21 00:14:57 PDT 2021
mkazantsev added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:1511
+ Value *LoadPtr = Load->getPointerOperand();
+ if (LoadPtr->canBeFreed())
+ return false;
----------------
reames wrote:
> In a follow up, please generalize by using stripping bitcasts and inbounds geps before calling canBeFreed. Please don't do this in the change being lgtmed now.
Shouldn't it be a part of `canBeFreed`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99926/new/
https://reviews.llvm.org/D99926
More information about the llvm-commits
mailing list