[PATCH] D100714: Add a new tutorial that talk about how to make a change to llvm.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/docs/MyFirstTypoFix.rst:324
+   $ git checkout -b myfirstpatch
+   $ git commit -am "Clarify -Winfinite-recursion message"
+
----------------
xgupta wrote:
> mehdi_amini wrote:
> > mehdi_amini wrote:
> > > xgupta wrote:
> > > > Beginners often forget to add a tag like for this patch Zhiqian didn't add [Docs] tag :)
> > > > Should be mention here.
> > > Is there a reference in an existing doc about the use of tags? I'm not sure we should tell beginners about things that aren't our documented norms.
> > > (I don't use any tag other than "NFC")
> > (I wouldn't see the need to add a tag to this very clear and explicit commit title for example)
> So It depends on the person, LLVM Project is large with around 100 commits a day. I don't read the complete line of commit/patch. A tag is useful for me.
> 
> So if it is not documented, we can document it. Otherwise, I left this on other reviewers and patch author to decide what is best.
Regardless, this seems to me to be out-of-line for a tutorial to define new conventions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100714/new/

https://reviews.llvm.org/D100714