[PATCH] D95543: [GVN] Clobber partially aliased loads.

Tue Apr 20 15:56:10 PDT 2021

dfukalov marked an inline comment as done.
dfukalov added inline comments.

================
Comment at: llvm/lib/Analysis/MemoryDependenceAnalysis.cpp:518
-      // at the clobbering load directly, it doesn't know about any
-      // phi translation that may have happened along the way.
-
----------------
dfukalov wrote:
> nikic wrote:
> > Do you have any information on why this is not a concern anymore? The comment was introduced in https://github.com/llvm/llvm-project/commit/a471751c24324e7ba6ac5c612dbedb16c644fc44, unfortunately without a test case :(
> Yes, I saw this change and because of this comment added VisitedPhiBBs check when [[ https://reviews.llvm.org/source/llvm-github/browse/main/llvm/lib/Analysis/BasicAliasAnalysis.cpp$1114 | we return PartialAlias with offset]] in BasicAAResult::aliasGEP.
I added test `load_load_partial_alias_cross_block_phi_trans` to check this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95543/new/

https://reviews.llvm.org/D95543