[PATCH] D100365: [AArch64] Fix windows vararg functions with floats in the fixed args

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 20 14:09:54 PDT 2021


mstorsjo added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp:167
                      MachineInstrBuilder MIB, CCAssignFn *AssignFn,
-                     CCAssignFn *AssignFnVarArg, bool IsTailCall = false,
-                     int FPDiff = 0)
+                     CCAssignFn *AssignFnVarArg, bool IsVarArg,
+                     bool IsTailCall = false, int FPDiff = 0)
----------------
arsenm wrote:
> You don't need to add this parameter, you can check the CCState::isVarArg in the assignment function
Ah, thanks! Patch upcoming.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100365/new/

https://reviews.llvm.org/D100365



More information about the llvm-commits mailing list