[lld] aa80955 - [lld-link] Warn on exported deleting dtor

[Zequan Wu via llvm-commits]

Author: Zequan Wu
Date: 2021-04-20T14:06:31-07:00
New Revision: aa80955f638f26360a1a137d69f61d5ac4970295

URL: https://github.com/llvm/llvm-project/commit/aa80955f638f26360a1a137d69f61d5ac4970295
DIFF: https://github.com/llvm/llvm-project/commit/aa80955f638f26360a1a137d69f61d5ac4970295.diff

LOG: [lld-link] Warn on exported deleting dtor

MSVC linker has this [[ https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-warning-lnk4102?view=msvc-160 | warning]], so lld-link should also warn on this.

Differential Revision: https://reviews.llvm.org/D100606

Added: 
    lld/test/COFF/export-deleting-dtor.s

Modified: 
    lld/COFF/Writer.cpp

Removed: 
    


################################################################################
diff  --git a/lld/COFF/Writer.cpp b/lld/COFF/Writer.cpp
index 09c456e648999..422a85c076386 100644
--- a/lld/COFF/Writer.cpp
+++ b/lld/COFF/Writer.cpp
@@ -1078,6 +1078,10 @@ void Writer::createExportTable() {
     edataStart = edataSec->chunks.front();
     edataEnd = edataSec->chunks.back();
   }
+  // Warn on exported deleting destructor.
+  for (auto e : config->exports)
+    if (e.sym && e.sym->getName().startswith("??_G"))
+      warn("export of deleting dtor: " + toString(*e.sym));
 }
 
 void Writer::removeUnusedSections() {

diff  --git a/lld/test/COFF/export-deleting-dtor.s b/lld/test/COFF/export-deleting-dtor.s
new file mode 100644
index 0000000000000..5d7b39ccb8e48
--- /dev/null
+++ b/lld/test/COFF/export-deleting-dtor.s
@@ -0,0 +1,26 @@
+# REQUIRES: x86
+
+# RUN: llvm-mc -triple=x86_64-windows-msvc -defsym drectve=0 %s -filetype=obj -o %t.obj
+# RUN: echo "EXPORTS  ??_GFoo@@UEAAPEAXI at Z" > %t.def
+
+# RUN: lld-link %t.obj -entry:dllmain -dll -export:'??_GFoo@@UEAAPEAXI at Z' -out:%t.1.dll 2>&1 | FileCheck %s
+
+# RUN: lld-link %t.obj -entry:dllmain -dll -def:%t.def -out:%t.2.dll 2>&1 | FileCheck %s
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-windows-msvc -defsym drectve=1 %s -o %t.drectve.obj
+# RUN: lld-link %t.drectve.obj -entry:dllmain -dll -out:%t.3.dll 2>&1 | FileCheck %s
+
+# CHECK: export of deleting dtor:{{.*}}Foo{{.*}}
+
+        .text
+        .globl  dllmain
+        .globl  "??_GFoo@@UEAAPEAXI at Z"
+dllmain:
+        ret
+"??_GFoo@@UEAAPEAXI at Z":
+        ret
+
+.if drectve==1
+        .section .drectve
+        .ascii "-export:??_GFoo@@UEAAPEAXI at Z"
+.endif