[PATCH] D88741: [SystemZ/z/OS] Add utility class for char set conversion.

Kai Nacke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 20 13:13:51 PDT 2021


Kai marked an inline comment as done.
Kai added inline comments.


================
Comment at: llvm/lib/Support/CharSet.cpp:89
+
+enum { NoUTF = 0x0, SrcIsUTF = 0x1, DstIsUTF = 0x2 };
+
----------------
fanbo-meng wrote:
> The naming here with "UTF" is ambiguous as it can mean UTF8, UTF16, UTF32. Using UTF8 with the enum names here would be better.
Renamed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88741/new/

https://reviews.llvm.org/D88741



More information about the llvm-commits mailing list