[PATCH] D100714: Add a new tutorial that talk about how to make a change to llvm.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 20 12:57:32 PDT 2021


mehdi_amini added inline comments.


================
Comment at: llvm/docs/MyFirstTypoFix.rst:324
+   $ git checkout -b myfirstpatch
+   $ git commit -am "Clarify -Winfinite-recursion message"
+
----------------
mehdi_amini wrote:
> xgupta wrote:
> > Beginners often forget to add a tag like for this patch Zhiqian didn't add [Docs] tag :)
> > Should be mention here.
> Is there a reference in an existing doc about the use of tags? I'm not sure we should tell beginners about things that aren't our documented norms.
> (I don't use any tag other than "NFC")
(I wouldn't see the need to add a tag to this very clear and explicit commit title for example)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100714/new/

https://reviews.llvm.org/D100714



More information about the llvm-commits mailing list