[PATCH] D100714: Add a new tutorial that talk about how to make a change to llvm.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/docs/MyFirstTypoFix.rst:128
+
+   $ cmake -G Ninja ../llvm -DCMAKE_BUILD_TYPE=Release DLLVM_ENABLE_PROJECTS=clang
+
----------------
For development purpose, I'd advise enabling assertions: `-DLLVM_ENABLE_ASSERTIONS=ON`.
(this is the default in DEBUG builds, but since you're enabling release build here...)


================
Comment at: llvm/docs/MyFirstTypoFix.rst:368-369
+with the previous commit. You will be prompted to fill in the review
+details. Your commit message is already there, so just add cfe-commits
+under the "subscribers" section. It should print a code review URL:
+https://reviews.llvm.org/D58291You can always find your active reviews
----------------
This is automatic in Phabricator I believe: the relevant list will be added based on the path in the monorepo.


================
Comment at: llvm/docs/MyFirstTypoFix.rst:437
+Review expectations
+-------------------
+
----------------
Seems like some other docs should be linked from this docs in the relevant sections, I don't see a ref to https://llvm.org/docs/CodeReview.html or https://llvm.org/docs/CodeReview.html for example.

( But also below in the revert section which like could link https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy )


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100714/new/

https://reviews.llvm.org/D100714