[PATCH] D91242: [RISCV] Custom lowering of SET_ROUNDING

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 20 12:53:48 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:41
   NearestTiesToAway = 4,    ///< roundTiesToAway.
+  MaxIEEEMode       = NearestTiesToAway,
 
----------------
This doesn't appear to be used in this patch. I don't object to adding it just wondering why it is in the RISCV patch.


================
Comment at: llvm/test/CodeGen/RISCV/fpenv.ll:57
+
+; COMMON-LABEL: func_03
+; COMMON:       fsrmi  1
----------------
COMMON doesn't appear in the runline in this test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91242/new/

https://reviews.llvm.org/D91242



More information about the llvm-commits mailing list