[PATCH] D100755: [llvm-rc] [3/4] Run clang to preprocess input files

[Eric Astor via Phabricator via llvm-commits]

epastor added inline comments.


================
Comment at: llvm/tools/llvm-rc/Opts.td:43
 
-def codepage : JS<"C", "Set the codepage used for input strings.">;
+def no_cpp : F<"no-cpp", "Don't try to preprocess the input file.">;
+
----------------
mstorsjo wrote:
> aganea wrote:
> > I know `-no-cpp` is short, but in my mind 'cpp' sounds like C++ not C preprocessor. I'm wondering if `-no-preprocess`  wouldn't be clearer?
> That might be a good idea.
+1 for this; I think `-no-preprocess` would be much clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100755/new/

https://reviews.llvm.org/D100755