[PATCH] D100235: [CSSPGO][llvm-profgen] Always report dangling probes for frames with real samples.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PseudoProbe.cpp:217
+    if (Root == Cur) {
+      // Use a sequential id for outline functions.
+      Index = Root->getChildren().size();
----------------
wenlei wrote:
> nit: outline function -> top level inliner.
Fixed.


================
Comment at: llvm/tools/llvm-profgen/PseudoProbe.h:74
 
+  auto &getChildren() { return Children; }
   void addProbes(PseudoProbe *Probe) { ProbeVector.push_back(Probe); }
----------------
wenlei wrote:
> Can we spell out the full return type? It seems we would use typedef if needed, but not so for `auto` return type.
Sounds good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100235/new/

https://reviews.llvm.org/D100235