[PATCH] D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529)

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

In D69428#2702157 <https://reviews.llvm.org/D69428#2702157>, @MaskRay wrote:

> The global variable may have readers but that readers can be optimized out. Then with this patch, such global variables will be optimized away and cause a leak.

FWIW, this example from @MaskRay seems pretty reasonable to me. I could see users annotating globals that catch intentional leaks, but adding annotations for this scenario (optimized-out reader) might make users feel like they're fighting the compiler. At least, seems like it might need some discussion outside of patch review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69428/new/

https://reviews.llvm.org/D69428