[PATCH] D99926: [GVN] Introduce loop load PRE

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

LGTM withdrawn due to issue noticed by Nikita.  Please address and refresh.



================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:1517
+  AvailableLoads[LoopBlock] = LoadPtr;
+  AvailableLoads[Preheader] = LoadPtr;
+
----------------
nikic wrote:
> Where do we check that LoadPtr is loop invariant (and thus available in preheader)?
Er good question, and good catch.  I remember this being here, but maybe it got lost in rebase.

Max, please add back the check, and a test which would have caught this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99926/new/

https://reviews.llvm.org/D99926