[PATCH] D99774: [LoopUtils] Populate sibling loops in reverse program order on new pass manager

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 20 10:50:44 PDT 2021


aeubanks added a comment.

I think we should stick with one way unless there's specific need otherwise. This patch overall is fine, multiple people have said that we should just stick with the legacy order unless somebody has a better idea.

The description is a bit verbose with unnecessary code snippets, could you clean that up a bit?



================
Comment at: llvm/lib/Transforms/Utils/LoopUtils.cpp:1496
 template <typename RangeT>
 void llvm::appendReversedLoopsToWorklist(
     RangeT &&Loops, SmallPriorityWorklist<Loop *, 4> &Worklist) {
----------------
this name and various comments need to be updated


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99774/new/

https://reviews.llvm.org/D99774



More information about the llvm-commits mailing list