[PATCH] D100868: [flang] Fix assignment of parameterized derived types

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld added inline comments.


================
Comment at: flang/lib/Semantics/tools.cpp:113
   } else {
-    const auto *lhsDerived{evaluate::GetDerivedTypeSpec(lhsType)};
-    const auto *rhsDerived{evaluate::GetDerivedTypeSpec(rhsType)};
-    if (lhsDerived && rhsDerived && *lhsDerived == *rhsDerived) {
-      return Tristate::Maybe; // TYPE(t) = TYPE(t) can be defined or
-                              // intrinsic
+    if (MightHaveCompatibleDerivedtypes(lhsType, rhsType)) {
+      return Tristate::Maybe; // TYPE(t) = TYPE(t) can be defined or intrinsic
----------------
klausler wrote:
> Minor: you can decrease the amount of block nesting here now, if you like, with an `else if`.
Thanks!  I'll do it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100868/new/

https://reviews.llvm.org/D100868