[PATCH] D100214: [AIX][TLS] Add support for TLSGD relocations to XCOFF objects

[Sean Fertile via Phabricator via llvm-commits]

sfertile added a comment.

Patch looks pretty good. IIUC we were not printing the '@gd' specifier before because it is assumed by default by the system assembler. Now that we are adding object file support we can no longer rely of the system assembler to assume the specifier based on the storage mapping class ,and need to add the new variant kinds so we create the correct relocations, which has the side effect of also changing the asm we emit. I know I am being pedantic, but I think we should land that part of the change and the update to the asm test in an initial patch even though the object writing is the motivation for adding it.



================
Comment at: llvm/lib/Target/PowerPC/PPC.h:132
+    /// to the variable offset of AIX TLS General Dynamic model.
+    MO_AIX_TLSGD_FLAG = 256,
+
----------------
Can we keep using the MO_TLSGD_FLAG for this, and differentiate based on checking that the system is AIX? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100214/new/

https://reviews.llvm.org/D100214