[PATCH] D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529)

[Sterling Augustine via Phabricator via llvm-commits]

saugustine added a comment.

The assumption is that memory still reachable at program termination, but not deallocated, has not leaked. And it is how all three of LSAN, Valgrind, and HeapLeakChecker define it.

That may not make sense in embedded environments, but that is how most leak checkers work (and in nonhosted environments, things are quite different anyway). FWIW, HeapLeakChecker does have a mode that checks for this, but it has been unused for many years.

At a previous company I worked for that did deeply embedded bare-metal development, there were absolutely cleanup functions that could deallocate all memory, available to be called at any time the program deemed it appropriate. I don't think that is all that unusual.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69428/new/

https://reviews.llvm.org/D69428