[PATCH] D98774: [AST] De-duplicate empty node introspection

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Definitely a step forward, so lg :)

> AFAIK python is not a hard-requirement of the llvm/clang build.

I think it is? https://llvm.org/docs/GettingStarted.html#software lists it at least.



================
Comment at: clang/lib/Tooling/CMakeLists.txt:96
+        --empty-implementation
+          "${CMAKE_CURRENT_SOURCE_DIR}/EmptyNodeIntrospection.inc.in"
       COMMAND
----------------
steveire wrote:
> thakis wrote:
> > What's the advantage of making a copy above? Why not call the checked-in file `EmptyNodeIntrospection.inc` and pass the path to it directly here?
> I'm not sure what you mean. The `configure_file` is inside the `if` and this line is inside the `else`. Does that clear it up?
Oh, I see. Maybe we could always call the py script and only make it copy through the empty file if the script isn't supposed to do anything?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98774/new/

https://reviews.llvm.org/D98774