[PATCH] D99083: [RISCV] Introduce floating point control and state registers

Tue Apr 20 08:25:12 PDT 2021

craig.topper added a comment.

In D99083#2700786 <https://reviews.llvm.org/D99083#2700786>, @sepavloff wrote:

> In D99083#2699994 <https://reviews.llvm.org/D99083#2699994>, @craig.topper wrote:
>
>> I don't think we should have unused pseudo instructions since they should all have lit tests. So if they can't be tested soon, they should be added when they are needed.
>
> Patches that implement FLT_ROUNDS_ (D90854 <https://reviews.llvm.org/D90854>) and SET_ROUNDING (D91242 <https://reviews.llvm.org/D91242>) use these instructions and they have tests. It it enough?

You said that there no patches ready that use the Swap pseudos or the fflags pseudos. Are those patches going to be created soon or should we remove the pseudos until they are used?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99083/new/

https://reviews.llvm.org/D99083