[PATCH] D100844: [DebugInfo] Salvage dbg.value() during ADCE
David Stenberg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 20 06:26:15 PDT 2021
dstenb added a comment.
Looks good. Just a small nit about the test.
================
Comment at: llvm/test/Transforms/ADCE/adce-salvage-dbg-value.ll:1
+;; Check that adce calls salvageDebugInfo() properly.
+; RUN: opt -adce -S < %s | FileCheck %s
----------------
Perhaps hide the implementation details here, and just say "Check that adce salvages debug info properly"?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100844/new/
https://reviews.llvm.org/D100844
More information about the llvm-commits
mailing list