[PATCH] D100624: [ELF] Don't set versionId on undefined weak lazy symbols

[Peter Smith via Phabricator via llvm-commits]

peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

LGTM.

If I've got this right:

- We assign versionid before LTO code generation
- We assign versionid to lazy symbols from script in case LTO fetches the symbol
- If the lazy symbol is not referenced we want to give it VER_NDX_GLOBAL so we have to do this at write time.

I'm trying to think if there is any reason we can't delay scanVersionScript() till after LTO code generation. If we could do that then we'd know which symbols were lazy and we wouldn't need to assign them a versionid. I don't know off the top of my head how much work it would be to check that though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100624/new/

https://reviews.llvm.org/D100624