[PATCH] D100475: llvm-objdump: move SourcePrinter to shared file

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 20 05:30:27 PDT 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nits.



================
Comment at: llvm/tools/llvm-objdump/SourcePrinter.cpp:482
+} // namespace llvm
\ No newline at end of file

----------------
Nit: add a new line at EOF.


================
Comment at: llvm/tools/llvm-objdump/SourcePrinter.h:164
+#endif
\ No newline at end of file

----------------
Nit: add a new line at EOF


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100475/new/

https://reviews.llvm.org/D100475



More information about the llvm-commits mailing list