[PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added a comment.

The diff context seems to have gone away again, I'm not sure what is happening there.

Since this code seems for the most part to be GISel-specific boilerplate, I don't really have a whole lot to contribute due to my lack of experience with GISel. For this part, I'm hoping that @arsenm and perhaps @kbarton can provide constructive feedback. And of course, than you Matt for the feedback you've provided so far.



================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCCallLowering.cpp:120
+
+  // define a lambda expression to load value
+  auto BuildLoad = [](MachineIRBuilder &MIRBuilder, MachinePointerInfo &MPO,
----------------
Minor nit: please use complete sentences in all comments - with capitalization and punctuation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99812/new/

https://reviews.llvm.org/D99812