[PATCH] D100812: [DAGCombiner] Allow operand of step_vector to be negative.

[JunMa via Phabricator via llvm-commits]

junparser added a comment.

In D100812#2700861 <https://reviews.llvm.org/D100812#2700861>, @paulwalker-arm wrote:

> I've nothing against the change but it is more involved than updating the comment and assert.  There are places where `STEP_VECTOR`'s operand is treated as unsigned, based on the original requirement, that will need to be updated.  For example `DAGTypeLegalizer::PromoteIntRes_STEP_VECTOR`.  Ideally we'd want to add/update tests to show the signedness is properly protected during type legalisation.

Yep, I'll update later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100812/new/

https://reviews.llvm.org/D100812