[PATCH] D100026: [X86] Support AMX fast register allocation

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 20 01:49:37 PDT 2021


xiangzhangllvm marked an inline comment as done.
xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:131
+      // Row = Row / 4
+      Row = getRowFromCol(II, Row, 4);
       Col = II->getArgOperand(1);
----------------
pengfei wrote:
> Can we always get the shape by the def of a AMX. Then we can avoid to add calculation for it.
> We can add assert here to make sure of it.
We just can pass Element Size into the AMX intrinsic def. The calculation still need.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100026/new/

https://reviews.llvm.org/D100026



More information about the llvm-commits mailing list