[PATCH] D100745: [AArch64] Add AArch64TTIImpl::getMaskedMemoryOpCost function
Caroline via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 20 01:44:40 PDT 2021
CarolineConcatto accepted this revision.
CarolineConcatto added a comment.
This revision is now accepted and ready to land.
@david-arm I believe this patch is ok.
If it is not possible to make masked stores illegal for fixed vector using isLegalMaskedLoadStore, then I believe that the cost model is another valid solution to avoid it for fixed vectors.
Thank you for the explanation earlier.
I am going to approve and let's hope that this will not be a curse like in Sander's cost model patch.
================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:921
+ unsigned AddressSpace,
+ TTI::TargetCostKind CostKind) {
+ if (!isa<ScalableVectorType>(Src)) {
----------------
Hey David, have you used clang-format or it is Phabricator?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100745/new/
https://reviews.llvm.org/D100745
More information about the llvm-commits
mailing list