[PATCH] D100681: llvm-objdump: add --rpaths to macho support

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/MachO/rpaths.test:1
+# Validate fetching rpaths from a binary results in the correct output
+# RUN: llvm-objdump --macho --rpaths --arch x86_64 %p/Inputs/Objc2.64bit.exe.macho-x86_64 | FileCheck %s
----------------
Nit: End comments with a '.'. Also, newer tests in the LLVM binutils tend to use '##' for comments, to help them stand out from lit and FileCheck directives.

Same applies to the other two comments below.


================
Comment at: llvm/test/tools/llvm-objdump/MachO/rpaths.test:11
+# Validate passing --rpaths without --macho fails
+# RUN: not llvm-objdump --rpaths %p/Inputs/hello.exe.macho-i386
----------------
You should capture and use FileCheck to check what error message is reported here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100681/new/

https://reviews.llvm.org/D100681