[PATCH] D100711: [ORC-RT] Initial ORC Runtime directories and build system files.

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 20 01:10:44 PDT 2021


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: compiler-rt/lib/orc/CMakeLists.txt:27-33
+# Make list that uses absolute paths
+set(ORC_ALL_SOURCE_FILES_ABS_PATHS "")
+foreach (src_file ${ORC_ALL_SOURCE_FILES})
+  list(APPEND
+    ORC_ALL_SOURCE_FILES_ABS_PATHS
+    "${CMAKE_CURRENT_SOURCE_DIR}/${src_file}")
+endforeach()
----------------
This looks unused and ideally shouldn't be needed at all since CMake doesn't require absolute paths.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100711/new/

https://reviews.llvm.org/D100711



More information about the llvm-commits mailing list