[PATCH] D74730: [FPEnv][X86] Implement lowering of llvm.set.rounding

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 19 23:11:13 PDT 2021


pengfei added a subscriber: LiuChen3.
pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:26949
+
+  // Store FP control word into memory.
+  SDValue Ops[] = {Chain, StackSlot};
----------------
I think we cannot assume x87 is always available https://godbolt.org/z/4MbsarMcP. GCC supports nox87 feature, @LiuChen3 is doing the same thing in LLVM in D100091.
Furthermore, do we need to add a function call in case softfloat/libcall is used? Can we wisely generate one of them based on situation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74730/new/

https://reviews.llvm.org/D74730



More information about the llvm-commits mailing list