[PATCH] D100026: [X86] Support AMX fast register allocation

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:96
+  ConstantInt *Gran = Builder.getInt16(Granularity);
+  Value *RealRow = Builder.CreateUDiv(V, Gran);
+  Col2Row[V] = RealRow;
----------------
Do we need to calculate the value in compile time if V is constant?


================
Comment at: llvm/lib/Target/X86/X86PreAMXConfig.cpp:69
+    if (Operand->getType()->isX86_AMXTy())
+      return false;
+  return II->getType()->isX86_AMXTy();
----------------
I don't understand the function. Does it mean only tilezero intrinsic return true?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100026/new/

https://reviews.llvm.org/D100026