[PATCH] D100718: Explicitly pass type to cast load constant folding result

Mon Apr 19 16:59:04 PDT 2021

dblaikie added a comment.

In D100718#2699142 <https://reviews.llvm.org/D100718#2699142>, @aeubanks wrote:

> I'm not 100% sure this is NFC, I think it's possible this might cause some behavior change with a very specific set of bitcasts, although it would be hard to reproduce since passes typically constant fold everything, not just one specific load instruction. But I built chrome with and without this change and it's the exact same size.

Fair enough. I'm a little uncomfortable if there could be an actual change here, committing it without a test for that - but if it's unlikely to be practical to hand-craft a test in a reasonable amount of time, I'm OK with you going ahead with it, then. Maybe add some caveats to the commit message to explain why there isn't a test here, but that it also might not be NFC, uin case anyone comes looking to try to root cause a bug, etc.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100718/new/

https://reviews.llvm.org/D100718