[llvm] cf899a3 - Add a cache of checked AttributeLists.

[Nick Lewycky via llvm-commits]

Author: Nick Lewycky
Date: 2021-04-19T16:01:06-07:00
New Revision: cf899a31aebf60e91a8732c6c5900398797230be

URL: https://github.com/llvm/llvm-project/commit/cf899a31aebf60e91a8732c6c5900398797230be
DIFF: https://github.com/llvm/llvm-project/commit/cf899a31aebf60e91a8732c6c5900398797230be.diff

LOG: Add a cache of checked AttributeLists.

Differential Revision: https://reviews.llvm.org/D100738

Added: 
    

Modified: 
    llvm/lib/IR/Verifier.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp
index 9d3c791995b1..83a48c4758d1 100644
--- a/llvm/lib/IR/Verifier.cpp
+++ b/llvm/lib/IR/Verifier.cpp
@@ -328,6 +328,9 @@ class Verifier : public InstVisitor<Verifier>, VerifierSupport {
   /// Cache of declarations of the llvm.experimental.deoptimize.<ty> intrinsic.
   SmallVector<const Function *, 4> DeoptimizeDeclarations;
 
+  /// Cache of attribute lists verified.
+  SmallPtrSet<const void *, 32> AttributeListsVisited;
+
   // Verify that this GlobalValue is only used in this module.
   // This map is used to avoid visiting uses twice. We can arrive at a user
   // twice, if they have multiple operands. In particular for very large
@@ -1890,14 +1893,16 @@ void Verifier::verifyFunctionAttrs(FunctionType *FT, AttributeList Attrs,
   if (Attrs.isEmpty())
     return;
 
-  Assert(Attrs.hasParentContext(Context),
-         "Attribute list does not match Module context!", &Attrs);
-  for (const auto &AttrSet : Attrs) {
-    Assert(!AttrSet.hasAttributes() || AttrSet.hasParentContext(Context),
-           "Attribute set does not match Module context!", &AttrSet);
-    for (const auto &A : AttrSet) {
-      Assert(A.hasParentContext(Context),
-             "Attribute does not match Module context!", &A);
+  if (AttributeListsVisited.insert(Attrs.getRawPointer()).second) {
+    Assert(Attrs.hasParentContext(Context),
+           "Attribute list does not match Module context!", &Attrs);
+    for (const auto &AttrSet : Attrs) {
+      Assert(!AttrSet.hasAttributes() || AttrSet.hasParentContext(Context),
+             "Attribute set does not match Module context!", &AttrSet);
+      for (const auto &A : AttrSet) {
+        Assert(A.hasParentContext(Context),
+               "Attribute does not match Module context!", &A);
+      }
     }
   }