[PATCH] D100797: Reset NextFnNum in MachineModuleInfo::initialize

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 19 15:07:35 PDT 2021


bogner added a comment.

In D100797#2699830 <https://reviews.llvm.org/D100797#2699830>, @bogner wrote:

> Probably better to switch all of these to C++11 style default member initializers and remove `initialize()` entirely. This is obviously correct either way though.

Oh, the MMI gets reused by the pass - to do this you'd need to also fix `finalize()` to properly clear these members (and maybe rename it `reset()` or so instead of tying this to the pass structure so tightly)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100797/new/

https://reviews.llvm.org/D100797



More information about the llvm-commits mailing list