[PATCH] D100738: Cache attribute checks

Mon Apr 19 14:32:32 PDT 2021

dexonsmith added a comment.

In D100738#2699767 <https://reviews.llvm.org/D100738#2699767>, @dexonsmith wrote:

> I triggered a run in the compile-time tracker for this patch:
> http://llvm-compile-time-tracker.com/compare.php?from=a7712091ea7a2b4a7b5c4764af7545a7574b651b&to=f01acba0cdc4625738be504449a71704595cd12f&stat=instructions
>
> Looks like an improvement, but I'm not how link time is exposed in that interface... or maybe it isn't? @nikic, you mentioned there was a 1% regression in link time: can you confirm if this fixes it?

Ah, I found it; the "per-file details" checkbox says it's .29% faster:

  tramp3d-v4	213713M	213394M (-0.15%)
      CMakeFiles/tramp3d-v4.dir/tramp3d-v4.cpp.o	100598M	100613M (+0.01%)
      tramp3d-v4.link	113114M	112781M (-0.29%)

for LegacyPM-ReleaseLTO-g, with my follow-up that adds attribute caching totally in the noise:

  tramp3d-v4	213394M	213318M (-0.04%)
      CMakeFiles/tramp3d-v4.dir/tramp3d-v4.cpp.o	100613M	100575M (-0.04%)
      tramp3d-v4.link	112781M	112744M (-0.03%)

This patch LGTM (certainly an improvement), but maybe this isn't quite enough. @nikic, thoughts?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100738/new/

https://reviews.llvm.org/D100738