[PATCH] D100583: [llvm-objdump] Add an llvm-otool tool

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: llvm/docs/CommandGuide/llvm-otool.rst:24
+
+ select slice of universal Mach-O file
+
----------------
The style for other utilities are capitalized descriptions and trailing periods.


================
Comment at: llvm/test/tools/llvm-objdump/MachO/relocations.test:14
+
+NONVERBOSE:      Relocation information (__TEXT,__text) 2 entries
+NONVERBOSE-NEXT: address  pcrel length extern type    scattered symbolnum/value
----------------
It'd be good to change CHECK to VERBOSE and NONVERBOSE to a normal prefix.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2870
+    FilterSections.push_back("__TEXT,__text");
+  NonVerbose = !(InputArgs.hasArg(OTOOL_v) || InputArgs.hasArg(OTOOL_V) ||
+                 InputArgs.hasArg(OTOOL_o));
----------------
Use "negative booleans", which may easily lead to double negations, especially that what have the positive option names now...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100583/new/

https://reviews.llvm.org/D100583