[PATCH] D100689: [funcattrs] Consistently check call site attributes

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: llvm/test/Transforms/FunctionAttrs/willreturn-callsites.ll:1
-; RUN: opt -function-attrs -S %s | FileCheck %s
+; RUN: opt -inferattrs -function-attrs -S %s | FileCheck %s
 
----------------
reames wrote:
> nikic wrote:
> > Why is the inferattrs here needed now?
> Because the declarations are only partially annotated, and func-attrs which is an CGSCC pass does not visit declarations, only inferattrs does.  
I'd personally prefer to add the missing nofree attributes to the declarations, so this only tests one pass. But I'm okay either way...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100689/new/

https://reviews.llvm.org/D100689