[PATCH] D98540: [M68k] Implement Disassembler

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu accepted this revision.
myhsu added a comment.
This revision is now accepted and ready to land.

conditionally LGTM.
Please fix the formatting issues before committing it. I think all of them are related to this coding style rule <https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements>.



================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:209
+    return false;
+  }
+
----------------
remove curly braces since there is only one statement in the body


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:218
+      return false;
+    }
+  }
----------------
ditto


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:238
+        dbgs() << " ";
+      }
+
----------------
remove curly braces since there is only one statement in the body


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:254
+      return true;
+    }
+  }
----------------
ditto


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:335
+          Builder.skipBits(3);
+        }
+
----------------
remove curly braces since there is only one statement in the body


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:339
+          Builder.skipBits(1);
+        }
+        break;
----------------
ditto


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:388
+      MIOpIdx += M68k::MemBase;
+    }
+  }
----------------
remove curly braces since there is only one statement in the body


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:409
+      MIOpIdx += M68k::MemDisp;
+    }
+  }
----------------
remove curly braces since there is only one statement in the body


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:423
+    Scratch = (Scratch & ~7) | Reader.readBits(3);
+  }
+
----------------
remove curly braces since there is only one statement in the body


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:431
+      Scratch &= ~8;
+    }
+  }
----------------
ditto


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:471
+    return Fail;
+  }
+
----------------
remove curly braces since there is only one statement in the body


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:479
+      continue;
+    }
+
----------------
ditto


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:492
+    return Fail;
+  }
+
----------------
ditto


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:569
+      continue;
+    }
+    unsigned SrcMIOpIdx = TiedTo;
----------------
remove curly braces since there is only one statement in the body


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98540/new/

https://reviews.llvm.org/D98540