[PATCH] D100717: [InstCombine] Transform memcpy to ptr load/stores if TBAA says so

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:177
+  Type* DataType = nullptr;
+  if (CopyMD && CopyMD->isTBAAPointerAccess() && SrcAddrSp == DstAddrSp &&
+      Size * 8 == DL.getPointerSizeInBits(SrcAddrSp)) {
----------------
arichardson wrote:
> I wonder if it would make sense to default to pointer load+store for non-integral address space?
> For CHERI we would definitely want this to be the default, but we can carry that patch downstream.
I'm not really sure why that would be the right default,
but regardless let's not conflate that here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100717/new/

https://reviews.llvm.org/D100717