[PATCH] D100551: [deref] No need to check nosync in addition to nofree

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D100551#2697733 <https://reviews.llvm.org/D100551#2697733>, @mkazantsev wrote:

> In D100551#2695408 <https://reviews.llvm.org/D100551#2695408>, @reames wrote:
>
>> I am really curious how you stumbled into this?  There's only one currently enabled case which uses this codepath, and it has an explicit check for the GC abstract machine model which should cover your use case as I understand it?
>
> I am planning to use this checker for loop load PRE. In case of concurrent GC, this check is too restrictive because nosync is never inferrable in practice.

Max, it might be worth talking offline about the specifics of your case.

In the abstract machine model, nosync should be inferrable in many cases.  In the abstract machine model, you also don't need to do, and there's an existing check in code.  (Which you might need to extend downstream.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100551/new/

https://reviews.llvm.org/D100551