[PATCH] D100332: [CSSPGO] Flip SkipPseudoOp to true for MIR APIs.

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:685-686
   /// unlikely hurt profile quality, e.g., without block merging.
   /// TODO: flip the default value of \c SkipPseudoOp to maximize code quality
   /// with pseudo probes.
+  iterator getFirstNonDebugInstr(bool SkipPseudoOp = true);
----------------
wmi wrote:
> TODO can be removed now. It maybe better to list the optimizations like branch folding and if-conversion here which set SkipPseudoOp to false as a reference.
Good point. Comment changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100332/new/

https://reviews.llvm.org/D100332