[PATCH] D100760: [AMDGPU] GCNDPPCombine: don't shrink V_ADD_CO_U32 if carry out is used

David Stuttard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 19 08:44:05 PDT 2021


dstuttard added a comment.

In D100760#2698681 <https://reviews.llvm.org/D100760#2698681>, @foad wrote:

> In D100760#2698668 <https://reviews.llvm.org/D100760#2698668>, @dstuttard wrote:
>
>> Only minor suggestion - maybe put in a TODO (or equiv) that we could handle this scenario as well (even with the shrinking. (I think).
>
> I'm reluctant to do that because I don't know how to handle it.

Ok - that's reasonable (I don't either)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100760/new/

https://reviews.llvm.org/D100760



More information about the llvm-commits mailing list