[PATCH] D100107: [AArch64][SVE] Combine add and index_vector

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen accepted this revision.
sdesmalen added a comment.

Other than my comment on two missing tests, the patch looks good to me.



================
Comment at: llvm/test/CodeGen/AArch64/sve-stepvector.ll:134
 
+define <vscale x 8 x i8> @add_stepvector_nxv8i8_2() {
+; CHECK-LABEL: add_stepvector_nxv8i8_2:
----------------
nit: I think you're still missing a test for the scalar+scalar case and one for imm+scalar (for start/stride respectively)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100107/new/

https://reviews.llvm.org/D100107