[PATCH] D75485: Support DW_FORM_strx* in llvm-dwp.

[Kim-Anh Tran via Phabricator via llvm-commits]

kimanh updated this revision to Diff 338512.
kimanh marked 3 inline comments as done.
kimanh added a comment.

Addressing reviewer comments:

- adding test on the header length, which changed test set
- removing accidentally added line in test
- removing obsolete comment
- update error messages to start with lower letter, and no new line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75485/new/

https://reviews.llvm.org/D75485

Files:
  llvm/test/tools/llvm-dwp/X86/invalid_cu_header_length.s
  llvm/test/tools/llvm-dwp/X86/invalid_cu_header_length_type.s
  llvm/test/tools/llvm-dwp/X86/invalid_cu_header_unittype.s
  llvm/test/tools/llvm-dwp/X86/invalid_cu_header_version.s
  llvm/test/tools/llvm-dwp/X86/invalid_string_form.test
  llvm/test/tools/llvm-dwp/X86/unsupported_cu_index_version.s
  llvm/tools/llvm-dwp/llvm-dwp.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75485.338512.patch
Type: text/x-patch
Size: 6360 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210419/90f07181/attachment.bin>