[PATCH] D100472: [X86][AMX] Verify illegal types or instructions for x86_amx.

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/test/Verifier/x86_amx1.ll:3
+
+ at GV = dso_local global [10 x x86_amx] zeroinitializer, align 16
+; CHECK: invalid array element type
----------------
LuoYuanke wrote:
> fhahn wrote:
> > LuoYuanke wrote:
> > > fhahn wrote:
> > > > can all those tests be in a single test file? I think the other verifier tests also group multiple checks in a single file
> > > Probably not. As llvm-as stops on the first error.
> > > 
> > > ```
> > > ; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s
> > > 
> > > define dso_local void @f() {
> > > entry:
> > >   %a.addr = alloca <2 x x86_amx>, align 4
> > >   ret void
> > > }
> > > 
> > > ; CHECK: invalid vector element type
> > > 
> > > 
> > > define void @f(x86_amx %A, x86_amx %B) {
> > > entry:
> > >   alloca x86_amx
> > > ; CHECK: invalid type for alloca
> > >   ret void
> > > }
> > > 
> > > ```
> > I'm not sure if there's a problem with the test matrix verifier tests or another difference, but I *think* the matrix verifier tests check multiple errors in a single file for example: https://github.com/llvm/llvm-project/blob/main/llvm/test/Verifier/matrix-intrinsics.ll
> I tested llvm/test/Verifier/matrix-intrinsics.ll. Yes this case is able to be grouped in a single file, but it is not the same to x86_amx test case. 
> 
> 
> ```
> [llvm]$ cat test/Verifier/x86_amx.ll
> ; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s
> 
> define dso_local void @f() {
> entry:
>   %a.addr = alloca <2 x x86_amx>, align 4
>   ret void
> }
> 
> ; CHECK: invalid vector element type
> 
> define void @f(x86_amx %A, x86_amx %B) {
> entry:
>   alloca x86_amx
> ; CHECK: invalid type for alloca
>   ret void
> }
> [llvm]$ llvm-as test/Verifier/x86_amx.ll
> llvm-as: test/Verifier/x86_amx.ll:5:25: error: invalid vector element type
>   %a.addr = alloca <2 x x86_amx>, align 4
>                         ^
> [llvm]$
> ```
It seems the token test cases are also not able to be grouped. 
test/Verifier/token1.ll
test/Verifier/token2.ll
test/Verifier/token3.ll


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100472/new/

https://reviews.llvm.org/D100472