[PATCH] D100761: Address reviewer comments

Kim-Anh Tran via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 19 07:00:06 PDT 2021


kimanh created this revision.
Herald added a subscriber: arphaman.
kimanh requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Addressing reviewer comments:

- adding test on the header length, which changed test set
- removing accidentally added line in test
- removing obsolete comment
- update error messages to start with lower letter, and no new line


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100761

Files:
  llvm/test/tools/llvm-dwp/X86/invalid_cu_header_length.s
  llvm/test/tools/llvm-dwp/X86/invalid_cu_header_length_type.s
  llvm/test/tools/llvm-dwp/X86/invalid_cu_header_unittype.s
  llvm/test/tools/llvm-dwp/X86/invalid_cu_header_version.s
  llvm/test/tools/llvm-dwp/X86/invalid_string_form.test
  llvm/test/tools/llvm-dwp/X86/unsupported_cu_index_version.s
  llvm/tools/llvm-dwp/llvm-dwp.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100761.338509.patch
Type: text/x-patch
Size: 6360 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210419/45cb0d32/attachment.bin>


More information about the llvm-commits mailing list